ENH: Add Axis Settings Modal#137
Merged
Merged
Conversation
Collaborator
Author
|
Just realized that I didn't include a way of changing the axis' name. This should be included in this settings modal, similar to the name in #138. |
e4568fc to
56df06a
Compare
Collaborator
Author
Holding off on this change for now. I talked with @shilorigins and we might make the axis labels in #139 editable instead. |
YektaY
approved these changes
Apr 22, 2025
YektaY
left a comment
Collaborator
There was a problem hiding this comment.
This looks good to me--you may want to add docstrings to some of the new methods. but that can also be done in a later pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a modal for controlling the settings of an axis.
The modal class,
AxisSettingsModal, takes in 3 arguments:The modal contains settings for:
PlotSettingsModal. This is done to keep the gridline opacity consistent across the plot