Skip to content

ENH: Adding X-Range Controls to Plot Settings#143

Merged
zdomke merged 4 commits into
ui_redesignfrom
zdomke/x-range-controls
Apr 23, 2025
Merged

ENH: Adding X-Range Controls to Plot Settings#143
zdomke merged 4 commits into
ui_redesignfrom
zdomke/x-range-controls

Conversation

@zdomke

@zdomke zdomke commented Apr 23, 2025

Copy link
Copy Markdown
Collaborator

Main Enhancement

Adding X-Axis controls to the PlotSettingsModal

  • Mimics PR: ENH: Update X-Axis from QDateTimeEdits #17
  • Added 2 new rows labeled "Start Time" and "End Time" each with a QDateTimeEdit to PlotSettingsModal
    • When a new date is set for either auto-scrolling will be turned off and the plot's x-axis will be changed
    • If the x-axis changes, the values in the QDateTimeEdits also change to reflect the updated x-axis range

Additional Fixes

Fix Auto-Scroll Interval

  • TraceDisplay did not have a slot connected to the signal PlotSettingsModal.auto_scroll_interval_change
  • Now it correctly adjusts the interval of the plot's auto scrolling feature by using the slot TraceDisplay.set_auto_scroll_interval

Constant for Disable Auto Scroll Button

  • Set a constant value for the value of TraceDisplay.disable_auto_scroll_button
  • Reasons for doing this:
    • It is set to a non-common value (-2) because -1 is a special value for QButtonGroups
    • The value is referenced in a couple places and the non-common value (-2) could cause confusion

@zdomke zdomke added the enhancement New feature or request label Apr 23, 2025
@zdomke zdomke added this to the Trace 1.5 milestone Apr 23, 2025
@zdomke zdomke requested a review from a team April 23, 2025 21:09
@zdomke zdomke self-assigned this Apr 23, 2025
@zdomke zdomke linked an issue Apr 23, 2025 that may be closed by this pull request
@zdomke zdomke merged commit 971c701 into ui_redesign Apr 23, 2025
@zdomke zdomke deleted the zdomke/x-range-controls branch April 23, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] - Redesign Trace

2 participants