Skip to content

FIX: Import & Export for UI Redesign#159

Merged
zdomke merged 14 commits into
ui_redesignfrom
zdomke/import-export
Jun 19, 2025
Merged

FIX: Import & Export for UI Redesign#159
zdomke merged 14 commits into
ui_redesignfrom
zdomke/import-export

Conversation

@zdomke

@zdomke zdomke commented Jun 2, 2025

Copy link
Copy Markdown
Collaborator

Description

Fix importing and exporting of config files for Trace. These features are now available under the Trace action menu in the top left of the app as Save, Save As..., and Open Trace Config....

  • Open Trace Config... action: Prompt the user for a file to open in Trace
    • Allows users to load config files for Trace (.trc), Striptool (.stp), or Java Archive tool (*.xml)
    • Will create the state saved in the config file (axes, curves, plot settings, etc.)
  • Save As... action: Prompt the user for a file to save the config to
    • Overwrites existing files if requested by the user
    • Only allows users to save as Trace config files (*.trc)
  • Save action: Saves any changes to the file that was opened last

Changes to ControlPanel class

Methods for adding curves and axes now return the CurveItem or AxisItem that is instantiated.
Added new methods for:

  • Removing all axes and curves from the ControlPanel
  • Getting an existing AxisItem
  • Setting all axes and curves in the ControlPanel

Changes to PlotSettingsModal class

Add new checkbox to enable/disable all Y-Axis gridlines.
Also added a new method for altering the settings of the plot based on a given config dictionary. Both of these changes are necessary for the import/export capabilities.

@zdomke zdomke added this to the Trace 1.5 milestone Jun 2, 2025
@zdomke zdomke self-assigned this Jun 2, 2025
@zdomke zdomke added the bug Something isn't working label Jun 2, 2025
@zdomke zdomke marked this pull request as draft June 2, 2025 21:06
@zdomke zdomke force-pushed the zdomke/import-export branch from 542117e to 0b48308 Compare June 4, 2025 17:41
@zdomke zdomke marked this pull request as ready for review June 9, 2025 20:29
@zdomke zdomke requested a review from a team June 9, 2025 20:29
@zdomke zdomke linked an issue Jun 9, 2025 that may be closed by this pull request
@zdomke

zdomke commented Jun 16, 2025

Copy link
Copy Markdown
Collaborator Author

Found a bug a little bit ago where curves do not successfully get removed from the plot before an import. This results in "dead" curves staying on the plot without a way of being removed.

Looking into this now.

@YektaY YektaY left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through the changes, and everything looks good to me. Great work!

@zdomke zdomke merged commit 0942348 into ui_redesign Jun 19, 2025
1 check passed
@zdomke zdomke deleted the zdomke/import-export branch August 7, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] - Move import/export actions

2 participants