FIX: Import & Export for UI Redesign#159
Merged
Merged
Conversation
542117e to
0b48308
Compare
Collaborator
Author
|
Found a bug a little bit ago where curves do not successfully get removed from the plot before an import. This results in "dead" curves staying on the plot without a way of being removed. Looking into this now. |
YektaY
approved these changes
Jun 17, 2025
YektaY
left a comment
Collaborator
There was a problem hiding this comment.
Read through the changes, and everything looks good to me. Great work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix importing and exporting of config files for Trace. These features are now available under the Trace action menu in the top left of the app as
Save,Save As..., andOpen Trace Config....Open Trace Config...action: Prompt the user for a file to open in TraceSave As...action: Prompt the user for a file to save the config toSaveaction: Saves any changes to the file that was opened lastSave As...actionChanges to
ControlPanelclassMethods for adding curves and axes now return the
CurveItemorAxisItemthat is instantiated.Added new methods for:
ControlPanelAxisItemControlPanelChanges to
PlotSettingsModalclassAdd new checkbox to enable/disable all Y-Axis gridlines.
Also added a new method for altering the settings of the plot based on a given config dictionary. Both of these changes are necessary for the import/export capabilities.