Data bins#164
Merged
Merged
Conversation
zdomke
requested changes
Aug 8, 2025
zdomke
left a comment
zdomke
left a comment
Collaborator
There was a problem hiding this comment.
This looks really good. Works well on my end, but I had a couple of design suggestions.
The main suggestion is moving the LineEdit into the CurveSettingsModal since we are going to try to clean up the CurveItem.
zdomke
approved these changes
Aug 19, 2025
zdomke
left a comment
zdomke
left a comment
Collaborator
There was a problem hiding this comment.
This PR looks good! Thank you for adding this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a QLineEdit to the control panel curve menu to allow setting the number of optimized bins to be requested from the archive