Add QMessagebox popup to confirm deleting axis#193
Merged
Conversation
zdomke
approved these changes
Sep 2, 2025
zdomke
left a comment
zdomke
left a comment
Collaborator
There was a problem hiding this comment.
Looks great!
My only suggestion is to remove an unnecessary import.
| import qtawesome as qta | ||
| from qtpy import QtGui, QtCore, QtWidgets | ||
| from qtpy.QtCore import QTimer | ||
| from PyQt5.QtWidgets import QMessageBox |
Collaborator
There was a problem hiding this comment.
Suggested change
| from PyQt5.QtWidgets import QMessageBox |
We import QtWidgets a couple lines above this. So you don't need to import the QMessageBox widget here.
Comment on lines
+648
to
+657
| dialog = QMessageBox( | ||
| text=str("Are you sure you want to delete the axis?"), | ||
| parent=self, | ||
| ) | ||
| dialog.setIcon(QMessageBox.Information) | ||
| dialog.setWindowTitle("Delete Axis") | ||
| dialog.setStandardButtons(QMessageBox.Ok | QMessageBox.Cancel) | ||
| result = dialog.exec_() | ||
|
|
||
| if result == QMessageBox.Cancel: |
Collaborator
There was a problem hiding this comment.
Suggested change
| dialog = QMessageBox( | |
| text=str("Are you sure you want to delete the axis?"), | |
| parent=self, | |
| ) | |
| dialog.setIcon(QMessageBox.Information) | |
| dialog.setWindowTitle("Delete Axis") | |
| dialog.setStandardButtons(QMessageBox.Ok | QMessageBox.Cancel) | |
| result = dialog.exec_() | |
| if result == QMessageBox.Cancel: | |
| dialog = QtWidgets.QMessageBox( | |
| text=str("Are you sure you want to delete the axis?"), | |
| parent=self, | |
| ) | |
| dialog.setIcon(QtWidgets.QMessageBox.Information) | |
| dialog.setWindowTitle("Delete Axis") | |
| dialog.setStandardButtons(QtWidgets.QMessageBox.Ok | QtWidgets.QMessageBox.Cancel) | |
| result = dialog.exec_() | |
| if result == QtWidgets.QMessageBox.Cancel: |
If we remove the import of QMessageBox above, then we need to reference it as QtWidgets.QMessageBox
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a QMessagebox popup to confirm deleting an axis
Motivation
This makes his harder to accidentally delete an axis
[FEATURE] - Pop up for deleting axis #165