ENH: New Curves Are Added to Axes Based on Units#198
Merged
Conversation
zdomke
force-pushed
the
zdomke/unit-axes
branch
from
057ac21 to
360e9b4
Compare
Collaborator
|
looks good to me |
YektaY
approved these changes
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a user creates a new curve, it is added to an axis based on the channels units (if the
.EGUfield is populated). If an axis for that unit does not exist, a new one will be created. The axes will have the unit as the name (e.g. '%', 'bara', 'deg_F').If a new curve does not have units (formula, no
.EGUfield, no live data) it will be added to a unitless axis named 'Axis 1' or something similar.Motivation
This groups like curves onto the same axes, giving the data context. This feature also existed before the UI was redesigned and it'd be nice to bring it back.
Closes SWAPPS-248
Screenshots
Pre-merge checklist