This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Updates for 0.12 #85
Merged
Updates for 0.12 #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulyoung
commented
Jun 27, 2018
| derive instance eqTextBox ∷ (Functor f, Eq (f String), Eq (f HN.HugeNum), Eq (f DT.Time), Eq (f DT.Date), Eq (f DT.DateTime)) ⇒ Eq (TextBox f) | ||
| derive instance ordTextBox ∷ (Functor f, Ord (f String), Ord (f HN.HugeNum), Ord (f DT.Time), Ord (f DT.Date), Ord (f DT.DateTime)) ⇒ Ord (TextBox f) | ||
| derive instance eqTextBox ∷ (Functor f, Eq (f String), Eq (f D.Decimal), Eq (f DT.Time), Eq (f DT.Date), Eq (f DT.DateTime), Eq1 f) ⇒ Eq (TextBox f) | ||
| derive instance ordTextBox ∷ (Functor f, Ord (f String), Ord (f D.Decimal), Ord (f DT.Time), Ord (f DT.Date), Ord (f DT.DateTime), Ord1 f) ⇒ Ord (TextBox f) |
Contributor
Author
There was a problem hiding this comment.
I don't understand this but I had to add Eq1 and Ord1 here to get this to type check.
I'm seeing this test failure locally:
Original:
(Right (SlamDown ((Paragraph ((FormField "name" false (TextBox (PlainText (Compose (Just (Literal "Phil Freeman")))))) : Nil)) : Nil)))
Printed:
(Right "name = ______ (Phil Freeman)\n")
Parsed:
(Right (SlamDown ((Paragraph ((FormField "name" false (TextBox (PlainText (Compose (Just (Literal "Phil Freeman")))))) : Nil)) : Nil)))
/Users/py/projects/slamdata/purescript-markdown/output/Data.Eq/index.js:13
var Eq1 = function (eq1) {
^
RangeError: Maximum call stack size exceeded
at new Eq1 (/Users/py/projects/slamdata/purescript-markdown/output/Data.Eq/index.js:13:20)
at /Users/py/projects/slamdata/purescript-markdown/output/Data.Functor.Compose/index.js:90:16
at /Users/py/projects/slamdata/purescript-markdown/output/Data.Functor.Compose/index.js:84:66
at /Users/py/projects/slamdata/purescript-markdown/output/Data.Functor.Compose/index.js:91:59
at /Users/py/projects/slamdata/purescript-markdown/output/Data.Functor.Compose/index.js:84:77
at /Users/py/projects/slamdata/purescript-markdown/output/Data.Functor.Compose/index.js:91:59
at /Users/py/projects/slamdata/purescript-markdown/output/Data.Functor.Compose/index.js:84:77
at /Users/py/projects/slamdata/purescript-markdown/output/Data.Functor.Compose/index.js:91:59
at /Users/py/projects/slamdata/purescript-markdown/output/Data.Functor.Compose/index.js:84:77
at /Users/py/projects/slamdata/purescript-markdown/output/Data.Functor.Compose/index.js:91:59
* ERROR: Subcommand terminated with exit code 1
Contributor
Author
There was a problem hiding this comment.
Well, not a test failure 😄
Contributor
Author
|
FWIW I opened purescript-contrib/purescript-precise#13 so we could keep using that if necessary. |
Contributor
Author
|
This now depends on my PR for Still getting a stack overflow: |
cryogenian
reviewed
Jun 27, 2018
|
|
||
| derive instance eqTextBox ∷ (Functor f, Eq (f String), Eq (f HN.HugeNum), Eq (f DT.Time), Eq (f DT.Date), Eq (f DT.DateTime)) ⇒ Eq (TextBox f) | ||
| derive instance ordTextBox ∷ (Functor f, Ord (f String), Ord (f HN.HugeNum), Ord (f DT.Time), Ord (f DT.Date), Ord (f DT.DateTime)) ⇒ Ord (TextBox f) | ||
| derive instance eqTextBox ∷ (Functor f, Eq (f String), Eq (f HN.HugeNum), Eq (f DT.Time), Eq (f DT.Date), Eq (f DT.DateTime), Eq1 f) ⇒ Eq (TextBox f) |
Member
There was a problem hiding this comment.
Maybe this should be
derive instance eqTextBox :: (Functor f, Eq1 f) => Eq (TextBox f)
derive instance ordTextBox :: (Functor f, Ord1 f) => Ord (TextBox f) 
Member
|
The fact travis is unhappy is very interesting, I'm not absolutely sure, but this might be somehow connected with |
This was referenced Jun 28, 2018
Open
paulyoung
commented
Jun 28, 2018
| derive instance eqTextBox ∷ (Functor f, Eq (f String), Eq (f HN.HugeNum), Eq (f DT.Time), Eq (f DT.Date), Eq (f DT.DateTime)) ⇒ Eq (TextBox f) | ||
| derive instance ordTextBox ∷ (Functor f, Ord (f String), Ord (f HN.HugeNum), Ord (f DT.Time), Ord (f DT.Date), Ord (f DT.DateTime)) ⇒ Ord (TextBox f) | ||
| derive instance eqTextBox ∷ (Functor f, Eq1 f) ⇒ Eq (TextBox f) | ||
| derive instance ordTextBox ∷ (Functor f, Ord1 f) ⇒ Ord (TextBox f) |
Contributor
Author
There was a problem hiding this comment.
I believe this is the code relating to the stack overflow.
Member
|
I'll take a look! |
Member
|
Ok, after much head scratching, it's a problem with I'll push some other changes into this branch though, as a lot of the |
Improve constraints, bump -functors for `Compose` fix, remove StrongCheck/generated stuff
Contributor
Author
|
I think this should be good now. Thanks @garyb! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few things to discuss here, which I'll point out.
I think the biggest change is usingsharkdp/purescript-decimalsinstead ofpurescript-contrib/purescript-precise. The former seems better maintained but has a JavaScript dependency.