feat: add optional slog.Logger support for observability#1
Merged
christiangda merged 4 commits intomainfrom Feb 14, 2026
Merged
feat: add optional slog.Logger support for observability#1christiangda merged 4 commits intomainfrom
christiangda merged 4 commits intomainfrom
Conversation
Add WithLogger(*slog.Logger) to Provider for optional logging with zero overhead when disabled. Logs component collection, fallback paths, command execution timing, and errors at Info/Warn/Debug levels. Also updates all code examples with context.Context parameter. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WithLogger(*slog.Logger)toProviderfor optional structured logging with zero overhead when disabled*slog.Loggerthrough all platform collectors (darwin, linux, windows), executor, and network functionscontext.ContextparameterTestWithLoggerOutputandTestWithoutLoggerNoOutputverification testsLog Levels
Test plan
go build ./...compiles across all platformsgo test -v -race -count=1 ./...— all tests passgo vet ./...— no warningsslog.NewTextHandlerandslog.NewJSONHandler🤖 Generated with Claude Code