Merged
Conversation
Owner
|
@KasperAndersson Hi Kasper, thank you for taking the time to submit this. I will review it 😊 |
slavanga
requested changes
Jul 2, 2022
Owner
slavanga
left a comment
slavanga
left a comment
There was a problem hiding this comment.
@KasperAndersson looks very good overall.
I left a few comments. Could you also add a new line after the last @use everywhere?
slavanga
approved these changes
Jul 5, 2022
Owner
|
@KasperAndersson perfect 👌 |
Contributor
Author
|
Hi @slavanga , do you plan to release this to npm registry? |
Owner
|
Hey @KasperAndersson the changes are released now: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16, or at least draft to..
cc @slavanga @W4ldgeist