Impl PartialEq, Eq, Hash for ActorRef

[realchonk]

No description provided.

[slawlor]

Why would you wan to do this? ActorId's exist for actor matching purposes, you shouldn't match on the full ActorRef ideally or use it as a key in a hash map

[slawlor]

We need a reasoning why this is necessary here.

[realchonk]

Sorry, in some project I store a list of attached ActorRef<Msg>s and a "sender" ActorRef<Msg>.
Then I have the following functions:

• reply(Msg) to send the message to sender
• broadcast(Msg) to send the message to all attached Actors
• and broadcast_except_sender(Msg)

For broadcast_except_sender(Msg) I have to do something like this:

for a in all_actors {
  if a.get_cell() != sender.get_cell() {
    // send
  }
}

I would like to be able to omit the .get_cell().

Sorry for the delay and not being able to be more specific,
as it's a work-related project.

[realchonk]

Previously I was also storing the actors in a HashSet, that's why I added the Hash derive.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.40%. Comparing base (9d77eca) to head (63fb425).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
ractor/src/actor/actor_ref.rs	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   82.44%   82.40%   -0.04%     
==========================================
  Files          71       71              
  Lines       12891    12897       +6     
==========================================
  Hits        10628    10628              
- Misses       2263     2269       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[realchonk]

thanks!