Merged
Conversation
`target/` (with trailing slash) only ignores directories, not the symlink created by the shared cargo target workflow (`target -> .shared-target`). Add `target` without the trailing slash so the symlink is also ignored. See docs/shared-cargo-target.md for context. Also fix a pre-existing clippy lint in vm-spawner (sort_by -> sort_by_key). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
target/(trailing slash) in.gitignoreonly matches directories, not symlinks. The shared cargo target setup creates atarget -> .shared-targetsymlink, which was showing up as untracked. Addingtarget(no trailing slash) fixes this.sort_by->sort_by_key).Test plan
git statusno longer showstargetas untracked🤖 Generated with Claude Code