Fix scroll jitter and add lightweight typing refresh#366
Merged
benthecarman merged 1 commit intosledtools:masterfrom Mar 1, 2026
Merged
Fix scroll jitter and add lightweight typing refresh#366benthecarman merged 1 commit intosledtools:masterfrom
benthecarman merged 1 commit intosledtools:masterfrom
Conversation
iOS: Replace manual diff logic in InvertedMessageList with UITableViewDiffableDataSource which handles index computation correctly and avoids unnecessary cell reconfiguration. Rust: Add refresh_typing_if_open for typing indicator updates without re-fetching messages from storage. Reverts the target cap which broke the UI by only sending 50 messages to the client. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
benthecarman
force-pushed
the
fix-refresh-cost
branch
from
56f91df to
a5a6014
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #364 (partial — typing indicator path)
Summary
InvertedMessageListwithUITableViewDiffableDataSourcefor correct index computation. Only apply snapshots when row IDs actually change to prevent scroll-blocking feedback loops.refresh_typing_if_openfor typing indicator updates without re-fetching messages from storage.Problem
insertRows/deleteRowsdiff used wrong indices, causing scroll jitter during paginationupdateUIViewwas called on every binding change (includingisAtBottomduring scroll), reapplying the data source snapshot and blocking scrollingrefresh_current_chatwhich re-fetches all loaded messages from storageTest plan
cargo clippyandcargo testpass🤖 Generated with Claude Code