Skip to content

pikachat-openclaw: harden reactions and typecheck against OpenClaw#367

Merged
futurepaul merged 1 commit intosledtools:masterfrom
futurepaul:pr-361-quality-fixes
Mar 2, 2026
Merged

pikachat-openclaw: harden reactions and typecheck against OpenClaw#367
futurepaul merged 1 commit intosledtools:masterfrom
futurepaul:pr-361-quality-fixes

Conversation

@futurepaul
Copy link
Collaborator

@futurepaul futurepaul commented Mar 2, 2026

Summary

  • keep the Nostr heart fallback (❤️) when reaction content is empty, while avoiding confusing agent context
  • convert inbound kind=7 reactions to passive session context using runtime.system.enqueueSystemEvent (aligned with default OpenClaw channel behavior)
  • await async sidecar send calls at all callsites to avoid unhandled rejection risk after PR pikachat-openclaw: surface event_id in agent context, filter inbound reactions (built on #342) #361 changes
  • tighten extension typing against OpenClaw SDK interfaces (message actions/tool factories/results), remove as any tool registration casts, and add openclaw as a dev dependency for real SDK type checking
  • add focused reaction helper tests

Why

PR #361 improved message-id semantics and action support, but introduced two quality risks:

  1. async sidecar sends could reject without being handled
  2. reaction events were dispatched through normal reply flow instead of passive context

This follow-up keeps the intended behavior while matching OpenClaw conventions and strict typing.

Testing

  • pnpm -C pikachat-openclaw/openclaw/extensions/pikachat-openclaw typecheck
  • cd pikachat-openclaw/openclaw/extensions/pikachat-openclaw && pnpm dlx tsx --test src/*.test.ts

Co-authored-by: waffledog-bot <forservicespam@gmail.com>
@futurepaul futurepaul force-pushed the pr-361-quality-fixes branch from 8506053 to 09175f8 Compare March 2, 2026 01:03
@futurepaul futurepaul merged commit e909e32 into sledtools:master Mar 2, 2026
15 checks passed
@futurepaul futurepaul deleted the pr-361-quality-fixes branch March 2, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant