Skip to content

fix(agent): preserve durable VMs and surface error state#460

Merged
justinmoon merged 1 commit intomasterfrom
microvm-v1-todos
Mar 6, 2026
Merged

fix(agent): preserve durable VMs and surface error state#460
justinmoon merged 1 commit intomasterfrom
microvm-v1-todos

Conversation

@justinmoon
Copy link
Copy Markdown
Collaborator

@justinmoon justinmoon commented Mar 6, 2026

Summary

  • move the deferred microvm v1 carryovers into a dedicated section at the end of todos/microvm-v2.md
  • stop personal-agent VMs from being reaped on the generic TTL path by marking them keep
  • let GET /v1/agents/me surface the latest error lifecycle row when no active row exists

Testing

  • cargo fmt
  • cargo test -p pika-agent-microvm
  • cargo test -p vm-spawner keep_vms_are_not_considered_expired -- --nocapture
  • cargo test -p pika-server agent_api::tests -- --nocapture

Open with Devin

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 6, 2026

Warning

Rate limit exceeded

@justinmoon has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 2 minutes and 57 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 34c59ae5-f0f5-41e6-90ff-e1085503171f

📥 Commits

Reviewing files that changed from the base of the PR and between 0e8bd59 and c6dd5c6.

📒 Files selected for processing (8)
  • crates/pika-agent-microvm/src/lib.rs
  • crates/pika-server/src/agent_api.rs
  • crates/pika-server/src/models/agent_instance.rs
  • crates/pika-server/src/models/mod.rs
  • crates/vm-spawner/src/manager.rs
  • crates/vm-spawner/src/models.rs
  • todos/microvm-v1.md
  • todos/microvm-v2.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch microvm-v1-todos

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

Open in Devin Review

@justinmoon justinmoon merged commit ac7e1f9 into master Mar 6, 2026
18 checks passed
@justinmoon justinmoon deleted the microvm-v1-todos branch March 6, 2026 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant