Add pikachatd / OpenClaw / Pi ACP refactor plan#488
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthroughA new comprehensive specification document detailing the refactor of pikachat into a transport-first runtime architecture. The plan outlines target crate structure, migration phases, service-oriented extraction, acceptance criteria, governance boundaries, and deprecation strategy while maintaining backward compatibility during transition. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
todos/pikachatd-openclaw-pi-acp-plan.md (2)
303-307: Optional: Consider varying sentence structure for readability.All five non-goal items begin with "Do not," which creates some repetition. While the content is clear, you could optionally rephrase for variety—for example, "Avoid embedding Pi-specific..." or "OpenClaw should not depend on ACP..."
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@todos/pikachatd-openclaw-pi-acp-plan.md` around lines 303 - 307, The four repeated "Do not" lines in the goals section are stylistically repetitive; reword them to vary sentence structure while preserving meaning—e.g., change "Do not make OpenClaw depend on ACP for its primary happy path" to "Avoid making OpenClaw depend on ACP for its primary happy path," change "Do not embed Pi-specific prompt logic into `pikachatd`" to "Avoid embedding Pi-specific prompt logic into `pikachatd`," and similarly vary the others referencing `OpenClaw`, `ACP`, `pikachatd`, `Pi`, and `pi-acp` so each line reads differently (use "Avoid," "Do not," or active phrasing) for improved readability.
226-229: Consider clarifying the "microVM agent path" concept.Item 16 references "the microVM agent path" without prior introduction in this document. While this may be well-understood in the project context, adding a brief note in the Target Architecture section or an earlier plan item would make this document more self-contained for future readers.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@todos/pikachatd-openclaw-pi-acp-plan.md` around lines 226 - 229, Clarify the undefined term "microVM agent path" referenced in Item 16 by adding a short explanatory sentence in the Target Architecture section (or an earlier plan item) that defines what the microVM agent path means in this project: e.g., that it refers to the execution flow where a microVM-launched agent binary (the ACP-capable agent such as "pi-acp") is started and communicated with via ACP rather than running Pi logic locally in pikachatd; update Item 16 to reference this definition so readers can understand that the acceptance criteria require pikachatd to invoke the microVM agent path and to drop any remaining Pika-owned local prompt execution, adapter fallback, or direct model HTTP fallback logic.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@todos/pikachatd-openclaw-pi-acp-plan.md`:
- Around line 303-307: The four repeated "Do not" lines in the goals section are
stylistically repetitive; reword them to vary sentence structure while
preserving meaning—e.g., change "Do not make OpenClaw depend on ACP for its
primary happy path" to "Avoid making OpenClaw depend on ACP for its primary
happy path," change "Do not embed Pi-specific prompt logic into `pikachatd`" to
"Avoid embedding Pi-specific prompt logic into `pikachatd`," and similarly vary
the others referencing `OpenClaw`, `ACP`, `pikachatd`, `Pi`, and `pi-acp` so
each line reads differently (use "Avoid," "Do not," or active phrasing) for
improved readability.
- Around line 226-229: Clarify the undefined term "microVM agent path"
referenced in Item 16 by adding a short explanatory sentence in the Target
Architecture section (or an earlier plan item) that defines what the microVM
agent path means in this project: e.g., that it refers to the execution flow
where a microVM-launched agent binary (the ACP-capable agent such as "pi-acp")
is started and communicated with via ACP rather than running Pi logic locally in
pikachatd; update Item 16 to reference this definition so readers can understand
that the acceptance criteria require pikachatd to invoke the microVM agent path
and to drop any remaining Pika-owned local prompt execution, adapter fallback,
or direct model HTTP fallback logic.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b374adb5-d04f-4b32-a453-97f40631c003
📒 Files selected for processing (1)
todos/pikachatd-openclaw-pi-acp-plan.md
Summary
todos/pikachatd-openclaw-pi-acp-plan.mddocumenting the plan to refactor pikachat into a transport-first runtime (pikachatd) with clear crate boundaries (pikachat-core,pikachat-protocol), an ACP bridge for serious agents like Pi, and preserved OpenClaw native protocol integration.Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit