Fix create_or_join to check for existing session before auto-suffixing#11
Merged
justinmoon merged 1 commit intomasterfrom Mar 4, 2026
Merged
Fix create_or_join to check for existing session before auto-suffixing#11justinmoon merged 1 commit intomasterfrom
justinmoon merged 1 commit intomasterfrom
Conversation
The auto-suffix feature caused create_or_join to create a new suffixed session instead of joining the existing one. Check if the session already exists upfront and return early if so.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the integration test failure from #10. The auto-suffix feature caused
create_or_jointo create a new suffixed session instead of joining the existing one. Now checks if the session already exists upfront and returns early.