Skip to content

Add tests and comment for SEQNO.RAW exclusion#250

Merged
ng merged 1 commit intodevfrom
chore/246-seqno-tests
Mar 22, 2026
Merged

Add tests and comment for SEQNO.RAW exclusion#250
ng merged 1 commit intodevfrom
chore/246-seqno-tests

Conversation

@ng
Copy link
Copy Markdown
Contributor

@ng ng commented Mar 22, 2026

Summary

  • Add inline comment explaining why SEQNO.RAW is excluded from _find_latest()
  • Add 4 unit tests for the exclusion behavior to guard against regression

Follow-up from adversarial review of #247.

Test plan

  • All 4 new tests pass
  • Covers: empty dir, SEQNO-only, SEQNO with newer mtime, multiple data files

🤖 Generated with Claude Code

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 22, 2026

Warning

Rate limit exceeded

@ng has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 0 minutes and 48 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0dca2fd9-71dc-473d-ac9b-2fd42927f462

📥 Commits

Reviewing files that changed from the base of the PR and between d62b952 and ae8c6d6.

📒 Files selected for processing (2)
  • modules/common/raw_follower.py
  • modules/common/test_raw_follower.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/246-seqno-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ng ng merged commit 8622713 into dev Mar 22, 2026
6 checks passed
@ng ng deleted the chore/246-seqno-tests branch March 22, 2026 21:01
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant