Skip to content

fix: lowercase app display name#30

Merged
ng merged 1 commit intomainfrom
fix/lowercase-display-name
Mar 22, 2026
Merged

fix: lowercase app display name#30
ng merged 1 commit intomainfrom
fix/lowercase-display-name

Conversation

@ng
Copy link
Copy Markdown
Contributor

@ng ng commented Mar 22, 2026

Fix remaining uppercase CFBundleDisplayName entries in Release and Test configurations.

Summary by CodeRabbit

  • Chores
    • Updated build configuration and project metadata to maintain consistency with development tools.

Note: This release contains internal build and configuration maintenance updates with no user-facing changes.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 22, 2026

📝 Walkthrough

Walkthrough

Modified Xcode project configuration settings in the Sleepypod iOS target. Updated test bundle file reference metadata, adjusted project upgrade compatibility version, added bundle display name to build configurations, and removed specific asset catalog and string catalog symbol generation settings.

Changes

Cohort / File(s) Summary
Xcode Project Configuration
Sleepypod.xcodeproj/project.pbxproj
Changed test bundle file reference from explicitFileType to lastKnownFileType, downgraded LastUpgradeCheck from 2620 to 2600, added INFOPLIST_KEY_CFBundleDisplayName = sleepypod to target build configs, and removed ASSETCATALOG_COMPILER_GENERATE_SWIFT_ASSET_SYMBOL_EXTENSIONS and STRING_CATALOG_GENERATE_SYMBOLS build settings.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 Hops through build configs with glee,
Settings adjusted, bundle name set free,
Symbol strings silenced, metadata's neat,
A sleepypod update, simply sweet!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: lowercase app display name' accurately describes the main change: adding INFOPLIST_KEY_CFBundleDisplayName with lowercase value to build configurations.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/lowercase-display-name

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (2)
Sleepypod.xcodeproj/project.pbxproj (2)

456-456: Unrelated change: LastUpgradeCheck downgraded from 2620 to 2600.

This change is unrelated to the display name fix. Downgrading this value is unusual and may cause Xcode to prompt for project upgrades when opened in newer versions. Was this intentional?

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Sleepypod.xcodeproj/project.pbxproj` at line 456, Revert the unintended
downgrade of LastUpgradeCheck: restore the value LastUpgradeCheck = 2620 (or
remove this line so the project file remains unchanged) to avoid forcing Xcode
to prompt for upgrades; locate the LastUpgradeCheck entry in the project.pbxproj
(the line currently set to 2600) and change it back to 2620.

179-179: Unrelated change: PBXFileReference metadata for test bundle.

This change from explicitFileType to lastKnownFileType is unrelated to lowercasing the display name. It's likely an artifact of Xcode re-saving the project file.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@Sleepypod.xcodeproj/project.pbxproj` at line 179, The PBXFileReference entry
for SleepypodTests.xctest was modified from explicitFileType to
lastKnownFileType as an unrelated Xcode artifact; revert that metadata change by
restoring the PBXFileReference for SleepypodTests.xctest (the record with isa =
PBXFileReference and path = SleepypodTests.xctest) to use the original
explicitFileType form and values instead of lastKnownFileType so the commit only
contains the intended display-name lowercase change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@Sleepypod.xcodeproj/project.pbxproj`:
- Line 456: Revert the unintended downgrade of LastUpgradeCheck: restore the
value LastUpgradeCheck = 2620 (or remove this line so the project file remains
unchanged) to avoid forcing Xcode to prompt for upgrades; locate the
LastUpgradeCheck entry in the project.pbxproj (the line currently set to 2600)
and change it back to 2620.
- Line 179: The PBXFileReference entry for SleepypodTests.xctest was modified
from explicitFileType to lastKnownFileType as an unrelated Xcode artifact;
revert that metadata change by restoring the PBXFileReference for
SleepypodTests.xctest (the record with isa = PBXFileReference and path =
SleepypodTests.xctest) to use the original explicitFileType form and values
instead of lastKnownFileType so the commit only contains the intended
display-name lowercase change.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: abe2f8ee-ba62-4b6a-9a8d-fde2e62687af

📥 Commits

Reviewing files that changed from the base of the PR and between 9f85709 and e1e939a.

📒 Files selected for processing (1)
  • Sleepypod.xcodeproj/project.pbxproj

@ng ng merged commit 826b31d into main Mar 22, 2026
2 checks passed
@ng ng deleted the fix/lowercase-display-name branch March 22, 2026 01:34
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant