feat: add [Finally] section and later assert modifier#20
Merged
Conversation
sleipi
changed the title
[Finally] section and later modifier to roadmap[Finally] section and later assert modifier
sleipi
force-pushed
the
feat/finally-section-and-later-modifier
branch
from
a900d59 to
4efe5ba
Compare
…VER entries - `later` keyword defers assert evaluation to file-end - `[Finally]` sends signal, checks exit code, evaluates post-signal asserts - Execution order: entries → later asserts → [Finally] LIFO → @defer LIFO - Process kept alive only when `later` or `[Finally]` present
Automatically inserts exec for simple commands in EXIT NEVER entries to ensure signals reach the target process directly on all /bin/sh implementations (bash, dash, ash). - Add internal/runner/helper.go with isSimpleCommand() and maybeExec() - Replace ps -p with kill -0 for Alpine compatibility - Add test-dash and test-ash Makefile targets - Add CI jobs for dash (Ubuntu), ash (Alpine), and bash (macOS) - Update SPEC.md and ROADMAP.md
sleipi
force-pushed
the
feat/finally-section-and-later-modifier
branch
from
4efe5ba to
275d3fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
[Finally]section andlaterassert modifier forEXIT NEVERentries (#19).Changes
laterkeyword — Defers assert evaluation to file-end instead of polling. Syntax:stdout contains later "value"[Finally]section — Sends a signal to background process, waits for exit, checks exit code, and evaluates post-signal asserts. Syntax:TERM EXIT 0 timeout 3000laterasserts or[Finally]section present; otherwise existing kill-on-timeout behavior unchangedFiles changed
internal/types/types.go—Assert.Later,Finallystruct,Entry.Finallyinternal/runner/runner.go—Signal(),ExitCode(),Wait()onBackgroundProcessinternal/parser/parser.go—laterkeyword parsing,[Finally]section parsinginternal/executor/executor.go—BackgroundEntry(),EvaluateLaterAsserts(),ExecuteFinally()cmd/clitest/run.go— Orchestration updated for new file-end flowSPEC.md— Documentedlatermodifier and[Finally]sectionROADMAP.md— Moved items to Completedit_evaluates_later_asserts.clitest,it_executes_finally_section.clitestResolves #19