Revert isPatternNext to isQuantifierNext #183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This add [babel-plugin-transform-xregexp] to the build process, which allows XRegExp to "self-host" in a sense. Note that `new Regexp()` is compiled to `/(?:)/`. [babel-plugin-transform-xregexp]: https://www.npmjs.com/package/babel-plugin-transform-xregexp
This makes the "Constructor with x flag, whitespace, and comments" test fast again. From slevithan#164 (comment): > A couple ideas: avoid the string concatenation in `isPatternNext` > (possibly going back to regex literals and making the function specific > to quantifiers again even though the current code is more > readable/maintainable, since this isn't needed to handle simple cases > with whitespace followed by `)`) Since babel-plugin-transform-xregexp automatically compiles the `new RegExp()` calls into literals, we get (most of) the performance back without sacrificing the readability of having separate subpatterns.
Owner
|
Awesome |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the "Constructor with x flag, whitespace, and comments" test
fast again. From
#164 (comment):
Since babel-plugin-transform-xregexp automatically compiles the
new RegExp()calls into literals, we get (most of) the performance backwithout sacrificing the readability of having separate subpatterns.