fix: add missing TimeGrid extends chain and full field definitions#3
Merged
slheavner merged 2 commits intoslheavner:mainfrom Mar 4, 2026
Merged
Conversation
TimeGrid was registered in data.ts with an empty fields array and no extends property, causing brighterscript-xml-plugin to report SG1002 (field not found) for all inherited Node/Group attributes such as 'id' and 'translation' when validating components that use TimeGrid. - Set extends to Group (which itself extends Node), restoring the full RSG inheritance chain: TimeGrid → Group → Node - Populated all 66 TimeGrid fields from the Roku developer docs (general settings, channel/program grid, time bar, now bar, now/next mode) - Added tests covering own-field completions, inherited-field completions (translation, id), and SG1002 absence for id and translation
slheavner
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
TimeGridwas registered indata.tswith an emptyfieldsarray and noextendsproperty. The validator'sfindAllFieldstraversal relies on theextendschain to walk up the RSG hierarchy, so it stopped atTimeGridand never reachedGrouporNode. This causedSG1002("Field not found") to fire for every inherited attribute — including universal ones likeidandtranslation— on any component that usedTimeGrid.Discovered and reproducible via jellyrock/jellyrock#347, a Renovate PR that bumped
brighterscript-xml-pluginand surfaced theSG1002errors on<JRTimeGrid id="scheduleGrid" translation="[0,600]" />.Changes
src/data.tsextendstoGroup(restoring the full RSG inheritance chain:TimeGrid → Group → Node)maxDays,duration,contentStartTime,autoDismissTime, …)animateToChannel,jumpToChannel,channelFocused, …)channelInfoWidth,channelInfoFocusable,channelInfoComponentName, …)programTitleColor,programFocused,fillProgramGaps, …)nowNextMode,nowBackgroundBitmapUri, …)src/XmlProvider.spec.tsThree new tests:
<TimeGridincludecontent,nowNextMode,programTitleColor,channelInfoWidthtranslationandvisible(fromGroup) andid(fromNode)<TimeGrid id="scheduleGrid" translation="[0,600]" />produces zeroSG1002diagnosticsTesting