Allow Slim to be used with Tilt 2.1.0 #910
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be great to be able to use Slim with Tilt 2.1.0 https://github.com/jeremyevans/tilt/blob/7907334d43afb53d37122470e5b346d235ad40c2/CHANGELOG.md#210-2023-02-17
Contributor
Author
|
The new Tilt maintainer explained the versioning scheme going forward at sinatra/sinatra#1884 (comment) so perhaps even changing to |
dentarg
added a commit
to dentarg/sinatra
that referenced
this pull request
Mar 5, 2023
Needed to run with Tilt 2.1.0 in CI: slim-template/slim#910
dentarg
added a commit
to sinatra/sinatra
that referenced
this pull request
Mar 5, 2023
Needed to run with Tilt 2.1.0 in CI until slim-template/slim#910 is part of a Slim release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be great to be able to use Slim with Tilt 2.1.0
The Sinatra framework have tests using both Tilt and Slim, but when the tests installs Tilt 2.1.0, a very old version of Slim (0.6.1) is used (I assume because it does not have any requirement on the version of Tilt): sinatra/sinatra#1884 (comment)