Closed
Conversation
holtkamp
force-pushed
the
patch-phpstan
branch
2 times, most recently
from
1323190 to
7468956
Compare
Add PHPStan Add PHPStan
holtkamp
force-pushed
the
patch-phpstan
branch
from
1725e82 to
6908103
Compare
Contributor
Author
|
Shameless bump on this ;) |
Member
|
If we're going to add phpstan we should add it to travis as well. |
milescook
suggested changes
Mar 31, 2020
| * ShutdownHandler constructor. | ||
| * | ||
| * @param Request $request | ||
| * @param $errorHandler $errorHandler |
There was a problem hiding this comment.
Perhaps keep this doc block in, but to correct the doc and keep phpstan happy, change to:
* @param HttpErrorHandler $errorHandler
I was about to create a PR but may as well piggy back off yours instead :)
Contributor
Author
There was a problem hiding this comment.
Sure, I was hoping for a "accept suggestion" button, but that seems not to be here...
Member
|
Resolved via #163 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.