Skip to content

Precision error fix for decimals on sql server#756

Open
shibba-96 wants to merge 1 commit into
slingdata-io:mainfrom
shibba-96:fix/sql-server-decimal-precision
Open

Precision error fix for decimals on sql server#756
shibba-96 wants to merge 1 commit into
slingdata-io:mainfrom
shibba-96:fix/sql-server-decimal-precision

Conversation

@shibba-96
Copy link
Copy Markdown

Fixes #720

Summary

  • Correctly applying precision of the SQL Server decimal values to destination

Refer to #720 for the full detail on the precision mismatch.

Test plan

  • Tested input noted on issue between SQL Server and Snowflake after rebuild via scripts/build.sh and running it with ./sling.
  • Able to product identical decimal precision seen on v1.3.4 and current version without column_typing configuration.
create transient table 
"SLING_TEST"."ALL_DTYPES_MSSQL_TMP" ("COL_MONEY" decimal(24,6),
  "COL_DECIMAL" decimal(10,2),
  "COL_DECIMAL2" decimal(28,8),
  "COL_DECIMAL3" decimal(16,8))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected decimal scale loading from SQL Server to Snowflake

2 participants