Remormat all the toml file again to fix npm upload #8041
Conversation
.mise/tasks.toml
Outdated
| ["fix:toml:format"] | ||
| description = "Run taplo format" | ||
| run = "taplo format" | ||
| run = "taplo format --option column_width=120" |
There was a problem hiding this comment.
This line was manually edited
There was a problem hiding this comment.
Could you please put that into .taplo.toml so that tooling will pick that up consistently? The VSCode extension of taplo will just ignore the change here as will the taplo LSP.
api/node/Cargo.toml
Outdated
| "backend-qt", | ||
| "accessibility", | ||
| ] | ||
| # This line is edited by the publish_npm_package.yaml workflow. Make sure it is only one line |
There was a problem hiding this comment.
This line was manually added
|
Let me see whether #8043 works out: That should fix the issue, too, and should work pretty independent of the format we chose to store the file on disk. It basically reformats with infinite columns, runs the scripts and formats back. |
|
This seems like a reasonable compromise to me. We still enforce formatting, but it's slightly simpler. |
tronical
left a comment
tronical
left a comment
There was a problem hiding this comment.
To me this change is an improvement:
- It's visually more pleasing
- It adds comments about the automated editing being done
- It also fixes the packaging
I think #8043 makes sense in parallel, as it makes the automated editing more robust, by itself.
|
I merged #8043, so the packaging should be fixed, only leaving the more pleasing and the added comment. As usual I have no strong opinion on the specifics of the configuration of a code formatter: I do not have to worry about formatting stuff myself and fixing spaces in code review. I would love the settings to move into .taplo.toml though, so people using the taplo LSP (e.g. via the taplo VSCode extension) also have the expected settings: [formatting]
column_width = 120should do this trick, but I did not test this. |
Commit cd6f2e2 reformated the .toml, but the 80 char width column is judged too small to be practical Add a .taplo.toml file
|
Rebased: Added a .taplo.toml I did two commit: What do you think? |
Commit cd6f2e2 reformated the .toml files but the formatter split some line that should have been kept in one line as other scripts were parsing the toml
Give a sane column with to avoid over-splitting of lines.
The broken script was
publish_nom_package.yamlthat changes the default in api/node/Cargo.toml