Handle partial bodies #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
Owner
|
Thanks, @tt! I'll get a new release pushed out to Hex with this and your other PR tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plug.Conn.read_bodywill by default read 8,000,000 bytes. If the body is larger, it results in an error as the return signature doesn't match.This reads 8,000,000 bytes as many times as necessary and use a stream implementation as is already the format accepted by HTTPoison. This might break with other HTTP clients but it's not really a breaking change and those would already be broken for bodies this large (and bodies below the default is not handled any differently).