Skip to content

Conversation

@tt
Copy link
Contributor

@tt tt commented Feb 10, 2017

If the upstream service uses chunked encoding, it will set the Transfer-Encoding header. HTTPoison will decode the chunks and return the entire body but it keeps the header. This results in a violation of the HTTP specification when the response is returned.

(I apologize that I missed this in #7.)

@coveralls
Copy link

coveralls commented Feb 10, 2017

Coverage Status

Coverage remained the same at 97.297% when pulling 267f736 on tt:drop-transfer-encoding-header into b435e03 on slogsdon:master.

@slogsdon slogsdon merged commit 0a54594 into slogsdon:master Feb 17, 2017
@slogsdon
Copy link
Owner

Thanks, @tt! I'll get a release with this pushed out soon.

@tt tt deleted the drop-transfer-encoding-header branch February 17, 2017 07:07
@tt
Copy link
Contributor Author

tt commented Feb 23, 2017

Thank you, @slogsdon.

@slogsdon
Copy link
Owner

@tt Apologies for the delay! This has been published as a part of v0.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants