fix: preserve conversation context across mode changes (#143) #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue where Happy was losing context during normal conversations, causing it to forget previous messages even within the same session. **Root Cause:** The remote launcher was calling `resetParentChain()` on every loop iteration, which happened whenever: - Message queue mode changed (permission mode, model, tools, etc.) - /clear or /compact commands were used - Any condition triggered a new claudeRemote() iteration This caused context loss even during normal multi-turn conversations. **Solution:** Track the session ID across loop iterations and only reset the parent chain when the session ID actually changes (new session started) or becomes null (/clear command). **Impact:** ✅ Normal multi-turn conversations now preserve context ✅ Permission mode changes preserve context ✅ Model changes preserve context ✅ /compact command preserves context ✅ /clear command still properly clears context Fixes #143 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
luxiaolei
force-pushed
the
fix/issue-143-context-loss
branch
from
fb9b37b to
1ff0ade
Compare
Contributor
Author
|
@bra1nDump could u pls review this one? |
4 tasks
jasonnoahchoi
pushed a commit
to jasonnoahchoi/happy-cli
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes slopus/happy#143 - Happy immediately forgets context in a conversation
Problem
Happy was losing conversation context during normal usage, causing it to forget previous messages even within the same session. Users reported it behaving as if /exit was typed constantly creating new conversations.
Root Cause
The remote launcher (src/claude/claudeRemoteLauncher.ts) was calling resetParentChain on every loop iteration, which happened whenever:
This broke the conversation chain and caused Claude to forget all previous context.
Solution
Modified the code to:
Impact
Testing
The fix has been verified with:
Files Changed
Closes slopus/happy#143