fix(ci): bump Node from 20 to 22 for acpx compatibility#977
Merged
Conversation
acpx@0.4.0 requires node >=22.12.0, which caused all Node 20 CI jobs to fail at yarn install after the acpx-rewrite merge. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The @slopus/happy-wire package was referenced but never created, causing TS2307 in CI. Define VoiceTokenResponse type and Zod schema inline. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
pkgroll treats dependencies as external, so npm install -g of the packed tarball tried to resolve @slopus/happy-sync from the npm registry (404). Moving it to devDependencies makes pkgroll bundle it into dist instead. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The postinstall script runs `npx tsc` which resolves to a broken doubled node_modules path on Windows CI. Skip the postinstall build and add an explicit build step for happy-sync before building the CLI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
npx tsc resolves to a broken doubled node_modules path on Windows CI with yarn workspaces. yarn scripts already add node_modules/.bin to PATH, so tsc works directly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
acpx@0.4.0requiresnode >=22.12.0, causing all Node 20 CI jobs to fail atyarn installafter PR Rewrite Happy to use acpx types end-to-end #976 mergedtypecheck.ymlfrom Node 20 → 22cli-smoke-test.ymlmatrix from[20, 24]→[22, 24](both Linux and Windows)Test plan
🤖 Generated with Claude Code