Skip to content

feat: Add DelayTimer Component for Real-Time Delay Measurement#230

Merged
slowlydev merged 6 commits intoslowlydev:developfrom
emilioh93:feature/delay-timer
Apr 15, 2025
Merged

feat: Add DelayTimer Component for Real-Time Delay Measurement#230
slowlydev merged 6 commits intoslowlydev:developfrom
emilioh93:feature/delay-timer

Conversation

@emilioh93
Copy link
Copy Markdown
Contributor

@emilioh93 emilioh93 commented Apr 15, 2025

Summary

This PR introduces a new component called DelayTimer, which allows users to measure the delay of the broadcast in real-time. The component integrates with the existing DelayInput, automatically updating its value while the timer is running.


Changes Made

  • Created the DelayTimer component, which includes:
    • A button that starts and stops the timer.
    • Real-time updates to the delay value in the DelayInput while the timer is active.
    • Styles consistent with the application's design.
  • Modified the dashboard layout to include the DelayTimer next to the DelayInput.
  • Updated the settings page to display the DelayTimer in the delay section.

Motivation

This change enhances the user experience by providing a more intuitive way to adjust the delay, especially useful for synchronizing live broadcasts with real-time data.

image
image

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 15, 2025

@emilioh93 is attempting to deploy a commit to the f1-dash Team on Vercel.

A member of the Team first needs to authorize it.

@emilioh93 emilioh93 changed the title feat: add DelayTimer component and integrate into settings and dashboard layouts feat: Add DelayTimer Component for Real-Time Delay Measurement Apr 15, 2025
@emilioh93 emilioh93 marked this pull request as ready for review April 15, 2025 01:42
@emilioh93 emilioh93 requested a review from slowlydev as a code owner April 15, 2025 01:42
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
f1-dash ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2025 11:09pm

Copy link
Copy Markdown
Owner

@slowlydev slowlydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this PR.

I got 2 things:

  1. Maybe we can use the PlayControls component instead of the start/ stop button.
  2. Starting and stopping the timer again resets the delay, which makes adjustments with the timer impossible.

What are your thoughts?

@slowlydev slowlydev changed the base branch from main to develop April 15, 2025 15:27
@emilioh93
Copy link
Copy Markdown
Contributor Author

Thank you for opening this PR.

I got 2 things:

  1. Maybe we can use the PlayControls component instead of the start/ stop button.
  2. Starting and stopping the timer again resets the delay, which makes adjustments with the timer impossible.

What are your thoughts?

Sure thing! these are very good suggestions. I will apply these changes this afternoon.

Copy link
Copy Markdown
Owner

@slowlydev slowlydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes, lgtm 🚀

@slowlydev slowlydev merged commit a9da3d4 into slowlydev:develop Apr 15, 2025
2 checks passed
B-a-1-a pushed a commit to B-a-1-a/HypeRacing that referenced this pull request Apr 25, 2025
feat: Add DelayTimer Component for Real-Time Delay Measurement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants