feat: Add DelayTimer Component for Real-Time Delay Measurement#230
Merged
slowlydev merged 6 commits intoslowlydev:developfrom Apr 15, 2025
Merged
feat: Add DelayTimer Component for Real-Time Delay Measurement#230slowlydev merged 6 commits intoslowlydev:developfrom
slowlydev merged 6 commits intoslowlydev:developfrom
Conversation
|
@emilioh93 is attempting to deploy a commit to the f1-dash Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
slowlydev
requested changes
Apr 15, 2025
Owner
There was a problem hiding this comment.
Thank you for opening this PR.
I got 2 things:
- Maybe we can use the
PlayControlscomponent instead of the start/ stop button. - Starting and stopping the timer again resets the delay, which makes adjustments with the timer impossible.
What are your thoughts?
Contributor
Author
Sure thing! these are very good suggestions. I will apply these changes this afternoon. |
…lace button with PlayControls component
slowlydev
approved these changes
Apr 15, 2025
Owner
slowlydev
left a comment
There was a problem hiding this comment.
thanks for the changes, lgtm 🚀
B-a-1-a
pushed a commit
to B-a-1-a/HypeRacing
that referenced
this pull request
Apr 25, 2025
feat: Add DelayTimer Component for Real-Time Delay Measurement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new component called
DelayTimer, which allows users to measure the delay of the broadcast in real-time. The component integrates with the existingDelayInput, automatically updating its value while the timer is running.Changes Made
DelayTimercomponent, which includes:DelayInputwhile the timer is active.DelayTimernext to theDelayInput.DelayTimerin the delay section.Motivation
This change enhances the user experience by providing a more intuitive way to adjust the delay, especially useful for synchronizing live broadcasts with real-time data.