css: distinguish multi-line entries in nav bar#840
Merged
MarkLodato merged 1 commit intoslsa-framework:mainfrom Apr 17, 2023
Merged
css: distinguish multi-line entries in nav bar#840MarkLodato merged 1 commit intoslsa-framework:mainfrom
MarkLodato merged 1 commit intoslsa-framework:mainfrom
Conversation
Previously the nav bar did not have any visual distinction between two different entries vs one entry with multiple lines - they all ran together. Now there is slightly more whitespace between entries and slightly less whitespace between lines within an entry, with all other spacing being *almost* pixel equivalent. Note: 0fa8c9d did this for the TOC, without being as careful about pixel equivalence. Signed-off-by: Mark Lodato <lodato@google.com>
✅ Deploy Preview for slsa ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
joshuagl
approved these changes
Apr 14, 2023
Member
joshuagl
left a comment
joshuagl
left a comment
There was a problem hiding this comment.
I won't pretend to understand the CSS, but the results look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the nav bar did not have any visual distinction between two different entries vs one entry with multiple lines - they all ran together.
Now there is slightly more whitespace between entries and slightly less whitespace between lines within an entry, with all other spacing being almost pixel equivalent.
Note: 0fa8c9d did this for the TOC, without being as careful about pixel equivalence.
To preview, compare "Verifying build platforms" and "For infrastructure providers" in the screenshots below, or flip back and forth between the netlify preview and the live site.