Skip to content

Bugfixes for LINEQN and floating-point string conversion #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 16, 2023
Merged

Bugfixes for LINEQN and floating-point string conversion #192

merged 2 commits into from
May 16, 2023

Conversation

@Joe7M
Copy link
Contributor

@Joe7M Joe7M commented May 14, 2023

Hi Chris,

here are fixes for the two bugs reported by jsalai (https://www.syntaxbomb.com/smallbasic/bug-s-in-lineqn/):

  • Tolerance in LINEQN is now applied in the intended way.
  • Floating-point to string conversion will round correctly when number has maximum possible precision.

Best regards, Joerg

chrisws
chrisws approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@chrisws chrisws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@chrisws chrisws merged commit ad194da into smallbasic:master May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisws chrisws chrisws approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Joe7M @chrisws