Skip to content

Bugfixes for LINEQN and floating-point string conversion #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2023
Merged

Bugfixes for LINEQN and floating-point string conversion #192

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
367d924
Fix floating-point number round-precision bug when converting a float…
Joe7M May 14, 2023
1128c5f
Fix bug: LINEQN tolerance
Joe7M May 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions samples/distro-examples/tests/all.bas
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,3 +245,4 @@ print "VAL:" + VAL (s)
print "WEEKDAY:" + WEEKDAY(dmy) + " " + WEEKDAY(1,1,2020) + " " + WEEKDAY(JULIAN(d,m,y))
print "XPOS:" + XPOS
print "YPOS:" + YPOS
print "RoundPrecisionBug:"; 32.99999999999999
1 change: 1 addition & 0 deletions samples/distro-examples/tests/output/all.out
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,3 +228,4 @@ VAL:0
WEEKDAY:-1 3 1
XPOS:0
YPOS:0
RoundPrecisionBug:33
2 changes: 1 addition & 1 deletion src/common/blib_math.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ void mat_gauss_jordan(var_num_t *a, var_num_t *b, int n, double toler) {
indxr[i] = irow;
indxc[i] = icol;

if (a[icol * n + icol] < toler) {
if (fabs(a[icol * n + icol]) < toler) {
err_matsig();
free(indxc);
free(indxr);
Expand Down
2 changes: 1 addition & 1 deletion src/common/fmt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ void bestfta_p(var_num_t x, char *dest, var_num_t minx, var_num_t maxx) {
}
fpart = fround(frac(x), precision) * pow(10, precision);

if (fpart >= FMT_xRND) { // rounding bug
if (fpart >= pow(10, precision)) { // rounding bug, i.e: print 32.99999999999999 -> Output: 32.1
ipart = ipart + 1.0;
if (ipart >= maxx) {
ipart = ipart / 10.0;
Expand Down