Skip to content

Drop path filters from Vale Prose Lint workflow#518

Merged
tashian merged 1 commit into
mainfrom
carl/vale-drop-path-filter
May 26, 2026
Merged

Drop path filters from Vale Prose Lint workflow#518
tashian merged 1 commit into
mainfrom
carl/vale-drop-path-filter

Conversation

@tashian
Copy link
Copy Markdown
Contributor

@tashian tashian commented May 26, 2026

Summary

  • Lint Prose is a required status check on main, but the workflow's path filters (**.mdx, **.md, .vale.ini, .vale/**) skip it on PRs that don't touch those paths.
  • When the workflow is skipped, the required check sits in "Expected — Waiting for status to be reported" forever, blocking the PR (see Ignore flaky omnissa.com and cr.yp.to URLs in link check #512).
  • Drop the path filters so Vale runs on every PR and the required check always reports. Vale is fast and a no-op when prose files don't change.

Test plan

  • This PR itself should be the first test: it touches no .md/.mdx/Vale config, so under the old filters Vale would skip; with the filters removed, the Lint Prose check should run and pass.

The `Lint Prose` job is a required status check on main, but the
workflow's path filters meant PRs that didn't touch Markdown/Vale
config files left the required check stuck in "Expected — Waiting
for status to be reported" indefinitely (e.g. #512).

Run Vale on every PR so the required check always reports. Vale
is fast and a no-op on PRs that don't change prose.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@tashian tashian requested a review from a team as a code owner May 26, 2026 14:21
@tashian tashian enabled auto-merge May 26, 2026 14:23
@tashian tashian merged commit d4accfb into main May 26, 2026
4 checks passed
@tashian tashian deleted the carl/vale-drop-path-filter branch May 26, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants