fix: address upstream review comments on TypedData migration#7
Merged
takaokouji merged 1 commit intomasterfrom Mar 29, 2026
Merged
fix: address upstream review comments on TypedData migration#7takaokouji merged 1 commit intomasterfrom
takaokouji merged 1 commit intomasterfrom
Conversation
- Add "ruby-sdl2/" prefix to type names in DEFINE_DATA_TYPE macro - Use RUBY_TYPED_FREE_IMMEDIATELY flag instead of 0 - Replace ALLOC + TypedData_Wrap_Struct with TypedData_Make_Struct Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
takaokouji
added a commit
to smalruby/smalruby3-editor
that referenced
this pull request
Mar 29, 2026
Update ruby-sdl2 to include upstream review feedback: - Add "ruby-sdl2/" prefix to type names - Use RUBY_TYPED_FREE_IMMEDIATELY flag - Use TypedData_Make_Struct across all files See smalruby/ruby-sdl2#7 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upstream PR (ohai#30) のレビューコメントに対応。
DEFINE_DATA_TYPEマクロの型名に"ruby-sdl2/"プレフィックスを追加0からRUBY_TYPED_FREE_IMMEDIATELYに変更ALLOC+TypedData_Wrap_StructをTypedData_Make_Structに統一Test Coverage
smalruby3コマンドで examples/01_move.rb の動作確認済みRelated