Merged
Conversation
When switching directly from furigana mode to DNCL mode, furigana annotations were not cleared because handleSelectDnclMode did not disable furigana. DNCL mode uses Japanese text, so furigana is redundant and should always be turned off. Fixes #514 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
🚀 Preview deployed: https://smalruby.jp/smalruby3-editor/fix/dncl-furigana-not-disabled/ |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 14, 2026
…gana-not-disabled fix: DNCLモード切替時にふりがなが消えない
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DNCLモード（日本語モード）は日本語表記のため、ふりがなは不要で常にOFFにすべき。しかし、「ふりがなモード → 日本語モード」に直接切り替えると、ふりがなが表示されたままになるバグがあった。
handleSelectDnclModeにふりがなOFF処理を1行追加して修正。Changes Made
ruby-toolbar.jsx:handleSelectDnclModeでふりがなが有効な場合にOFFにする処理を追加（handleSelectRubyModeと同じパターン）Definition of Done
Fixes #514