fix: Mesh ステータス/接続モーダルが scanning で固まる不具合を修正#657
Merged
takaokouji merged 1 commit intodevelopfrom May 8, 2026
Merged
Conversation
…rves the real extension id Blockly v12's ContinuousToolbox parses category id from the toolboxitemid attribute (iI.id_ = e.toolboxitemid || genUid()). Our extension category XML only carried the legacy id attribute, so v12 fell back to genUid() and assigned the category an auto id like blockly-1aw. That id propagated to StatusIndicatorLabel.extensionId. When the user clicked the warning ! status icon next to a mesh / micro:bit / similar extension, the connection modal opened with extensionId set to the bogus blockly-* id. The container could not resolve the extension, so it skipped meshV2Initial and fell through to the default scanning step. vm.connectPeripheral was a no-op because no peripheral extension matches blockly-1aw, so PERIPHERAL_CONNECTED never fired and the modal stayed at scanning forever (header showed blockly-1aw, status icon stayed !). Emit toolboxitemid alongside id so the v12 parser keeps the extension's real id, and add a tap test pinning the XML format. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
🚀 Preview deployed: https://smalruby.jp/smalruby3-editor/fix/mesh-host-connected-status/ |
github-actions Bot
pushed a commit
that referenced
this pull request
May 8, 2026
…-connected-status fix: Mesh ステータス/接続モーダルが scanning で固まる不具合を修正
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mesh拡張機能を有効にしてホストになっても、メッシュのステータス（
!切断アイコン）が更新されず、接続モーダルがスキャン画面のまま固まる不具合を修正します。Root cause
Blockly v12 の
ContinuousToolboxはtoolboxitemid属性 からカテゴリ id を読みます (iI.id_ = e.toolboxitemid || genUid())。runtime.jsが拡張機能カテゴリ XML を生成する際、id="..."のみを付与していたため、v12 のパーサはgenUid()にフォールバックし、blockly-1awのような auto id をカテゴリに付けます。ユーザーが
!警告アイコンをクリックすると、その auto id (blockly-1aw) がstatusButtonCallbackに渡され、連鎖的に:extensionId="blockly-1aw"で開くextensionData.find(ext => ext.extensionId === 'blockly-1aw')が undefined →MeshV2InitialStepに行かずscanningフェーズへフォールバックvm.connectPeripheral('blockly-1aw', 'meshV2_host')は no-op（runtime.peripheralExtensions['blockly-1aw']が undefined）PERIPHERAL_CONNECTEDが永遠に発火しないので、モーダルは「デバイスを探索中」の scanning ステップのまま固まる!のままライブの workspace で flyout の
StatusIndicatorLabel.extensionIdを覗くと、修正前は"blockly-1aw"、修正後は"meshV2"になることを確認しました。Fix
packages/scratch-vm/src/engine/runtime.jsで拡張機能カテゴリ XML にtoolboxitemid="${id}"をid="${id}"と並べて付与します（v12 推奨のtoolboxitemidを新規・古いidを残す）。これは upstream ファイルへの修正のため Smalruby マーカーを使用し、
.claude/rules/scratch-vm/development.mdの一覧も更新しました。Changes
packages/scratch-vm/src/engine/runtime.js— XML にtoolboxitemidを追加packages/scratch-vm/test/unit/runtime_extension_category_xml.js(新規) — XML がtoolboxitemid/id/showStatusButtonをすべて含むことを検証する tap テスト.claude/rules/scratch-vm/development.md— マーカー一覧を更新Test plan
StatusIndicatorLabel.extensionId === "meshV2"（修正前は"blockly-1aw"）→statusButtonCallback経由で接続モーダルがextensionId="meshV2"で開く🤖 Generated with Claude Code