This repository was archived by the owner on May 18, 2026. It is now read-only.
feat: add default hidden functionality to extension library#515
Merged
Conversation
- Create extension-filter reducer to manage showAllExtensions state - Add defaultHidden: true to Makey Makey, micro:bit, LEGO EV3, LEGO BOOST, WeDo 2.0, and Go Direct Force & Acceleration - Implement headerActions pattern in Modal component - Add 'Show all extensions' checkbox to ExtensionLibrary - Persist showAllExtensions setting in localStorage - Add translations for the new checkbox label Fixes smalruby/smalruby3-develop#18 Co-Authored-By: Gemini <noreply@google.com>
19 tasks
- Change microbitMore name to 'micro:bit' - Update description to include 'with Microbit More' - Update Japanese and German translations accordingly - Add 'mbit' to cspell.json Co-Authored-By: Gemini <noreply@google.com>
…ensions - Extension IDs are strings, but LibraryItem expected only numbers. - Updated id PropType to accept both numbers and strings. Fixes PropType warning in extension library modal.
…nd accessibility enhancements - Allow ?showAllExtensions=true/false to override localStorage settings - Migrate KoshienTestModal to use headerActions pattern - Add aria-label to 'Show all extensions' checkbox for screen readers Co-Authored-By: Gemini <noreply@google.com>
- Removed onReload and onStop from propTypes and conditional rendering logic. - Removed unused reloadIcon and stopIcon imports. - Kept loading state and progressBar functionality as they are still used. Co-Authored-By: Gemini <noreply@google.com>
- Removed onReload and onStop from propTypes and conditional rendering logic. - Removed unused reloadIcon and stopIcon imports. - Kept loading state and progressBar functionality as they are still used. Co-Authored-By: Gemini <noreply@google.com>
- Modified SeleniumHelper.loadUri to automatically append showAllExtensions=true to the test URI. - This ensures that hidden extensions like EV3 are accessible to tests that interact with the extension library UI. - Fixes CI failure in test/integration/connection-modal.test.js. Co-Authored-By: Gemini <noreply@google.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Jan 14, 2026
…-extension-filter feat: add default hidden functionality to extension library
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to hide certain extensions by default in the extension library, as requested in smalruby/smalruby3-develop#18.
Changes:
extension-filter.jsto manageshowAllExtensionsstate and integrated it intogui.js.defaultHidden: truetomakeymakey,microbit,ev3,boost,wedo2, andgdxforinlib/libraries/extensions/index.jsx.Modalcomponent to supportheaderActionsprop (Generic pattern).LibraryComponentto passheaderActionstoModal.ExtensionLibrarycontainer to provide the "Show all extensions" checkbox.extension-library.cssand updatedmodal.css.gui.extensionLibrary.showAllExtensionstoen.js,ja.js, andja-Hira.js.Verification:
npm run test:lintpassed.npm run buildpassed.Fixes smalruby/smalruby3-develop#18