fix(049): classifyServerToolStatus runtime config authority#477
Merged
Conversation
The merged #476 classifyServerToolStatus read config-denial only from the storage ServerConfig copy. Config-file disabled_tools on stdio servers live in the live runtime config and are not always mirrored to storage, so disabled_by_config classification + upstream_servers counts were wrong at runtime for that case (unit tests passed because the no-runtime harness uses the storage fallback path). Prefer p.mainServer.runtime.IsToolConfigDenied (same authority isToolCallable/blockedToolMessage use); fall back to storage IsToolAllowedByConfig only when no runtime is wired. Adds a runtime regression test pinning that ClassifyDisabledTool reads live config (the authority the server layer now delegates to). Related #468
Deploying mcpproxy-docs with
|
| Latest commit: |
95bd1f9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://da823905.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://049-fix-runtime-config-denie.mcpproxy-docs.pages.dev |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 26035662104 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up correctness fix to #476 (spec 049).
#476's
classifyServerToolStatusderived config-denial only from the storageServerConfigcopy. For config-filedisabled_toolson stdio servers, that value lives in the live runtime config and is not always mirrored into storage — sodisabled_by_configclassification andupstream_serverstool counts were wrong at runtime for that case. (Unit tests passed because the no-runtime test harness exercises the storage fallback path; the gap was found during live curl/MCP verification and documented inspecs/049-…/quickstart.md.)Fix
classifyServerToolStatusnow prefersruntime.IsToolConfigDenied(the same authorityisToolCallable/blockedToolMessageuse); falls back to storageIsToolAllowedByConfigonly when no runtime is wired (unit tests).TestClassifyDisabledTool_ConfigFromLiveConfigpinning that the runtime classifier reads live config (the authority the server layer delegates to).No behavior change on the default path; no storage/enforcement change.
Related #468