fix(069-B2): green dashboard-usage-switcher unit tests (MCP-900)#576
Merged
Conversation
The 069-B1 switcher tests broke when 069-B2 (#571) swapped the inline usage panel for the real async Usage.vue. Two mount-side problems: - The usage panel wrapper carried v-if="usageEverActive", so it was absent from the DOM on first paint and the exists() assertion failed. Move the lazy gate onto the inner <Suspense> instead: the wrapper div is now always present (hidden via v-show), while the chart bundle + usage fetch inside UsageView still mount only on first switch (SC-004), and the Overview subtree is preserved across switches (SC-006). - shallowMount stubbed both <Suspense> and the async UsageView, so the real Usage.vue never rendered (no fetch, no window buttons). Un-stub Suspense and swap the async wrapper for an eagerly-imported Usage.vue so the fetch-on-activation and window-re-fetch logic actually runs; a dynamic import() never settles inside flushPromises + Suspense. Usage's chart grandchildren stay shallow-stubbed (no jsdom canvas). Related #571
Deploying mcpproxy-docs with
|
| Latest commit: |
8a6a240
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ac222acb.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-069-b2-dashboard-usage-t.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 26842454773 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Frontend CI lane is red on `main`. `frontend/tests/unit/dashboard-usage-switcher.spec.ts` (added in 069-B1 #570) broke when 069-B2 (#571) swapped the inline usage panel for the real async `Usage.vue`. Every `frontend/**` PR now fails the merge gate.
Failures (reproduced on clean `origin/main`)
defaults to the Overview tab …—[data-test="dashboard-usage-panel"]absent from the mounted DOM.switches to Usage … lazily fetches the aggregate— usage fetch spy called 0 times.re-fetches with the selected window …—Cannot call trigger on an empty DOMWrapperfor[data-test="usage-window-7d"].Root cause (mount-side, two parts)
v-if="usageEverActive", so it was absent on first paint (failedexists()).shallowMountstubbed both<Suspense>and the asyncUsageView, so the realUsage.vuenever rendered — no fetch fired and its window buttons never existed.Fix
Dashboard.vue— move the lazy gate from the wrapper onto the inner<Suspense v-if="usageEverActive">. The panel wrapper is now always in the DOM (hidden viav-show), while the chart bundle + usage fetch insideUsageViewstill mount only on first switch. Preserves SC-004 (no usage fetch / chart bundle on first paint — Usage still code-splits into its own chunk) and SC-006 (Overview subtree never torn down). No user-facing behavior change.test — un-stub
<Suspense>and swap the asyncUsageViewfor an eagerly-importedUsage.vue(a dynamicimport()never settles insideflushPromises+ Suspense, leaving the panel stuck on its fallback spinner). The genuine switcher fetch-on-activation + window-re-fetch logic now runs; Usage's chart grandchildren stay shallow-stubbed so jsdom never touches a canvas.Verification
vitest run dashboard-usage-switcher.spec.ts→ 4/4 passvitest run(full frontend suite) → 91/91 passvue-tsc --noEmit→ cleanvite build→ clean (Usage still code-splits)Unblocks MCP-867 (#575). Related #571