New response_format and request_fallback parameters#128
Merged
Conversation
…deserializers to jms. Rethrow deserialization errors by default
…ities: 1. Overridden value on the flow definition 2. Producer default encoding 3. JSON + trigger deprecation error on fallback when no response_format is defined
…ll default to true (fallback enabeld) and can be disabled to force an exception by setting it to false
andreskrey
changed the title
campru
reviewed
May 6, 2020
campru
reviewed
May 6, 2020
campru
reviewed
May 6, 2020
campru
reviewed
May 6, 2020
campru
reviewed
May 6, 2020
campru
reviewed
May 6, 2020
campru
suggested changes
May 6, 2020
Contributor
campru
left a comment
campru
left a comment
There was a problem hiding this comment.
I have reviewed the changes and there are small things that should be addressed. It would also be interesting to add a architecture decision record explaining why we decided this
Co-authored-by: David Camprubí <david.camprubi@smartbox.com>
Contributor
Author
|
All comments addressed |
campru
reviewed
May 7, 2020
Contributor
|
The changes have been reviewed and are fine. Could you add here a architecture decision record for this? |
Contributor
Author
|
Done |
campru
reviewed
May 11, 2020
campru
reviewed
May 11, 2020
campru
reviewed
May 11, 2020
campru
reviewed
May 11, 2020
campru
reviewed
May 11, 2020
campru
reviewed
May 11, 2020
campru
reviewed
May 11, 2020
Co-authored-by: David Camprubí <david.camprubi@smartbox.com>
Co-authored-by: David Camprubí <david.camprubi@smartbox.com>
Co-authored-by: David Camprubí <david.camprubi@smartbox.com>
Co-authored-by: David Camprubí <david.camprubi@smartbox.com>
Co-authored-by: David Camprubí <david.camprubi@smartbox.com>
Co-authored-by: David Camprubí <david.camprubi@smartbox.com>
Co-authored-by: David Camprubí <david.camprubi@smartbox.com>
campru
approved these changes
May 11, 2020
Contributor
campru
left a comment
campru
left a comment
There was a problem hiding this comment.
The changes have been reviewed and can be merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two new parameters: