Skip to content

Conversation

@EvanPeterson1324
Copy link
Contributor

Overview

Adds get charge limit and set charge limit for electric vehicles

Asana: https://app.asana.com/0/1204073873904879/1204302264096980/f

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (f2a724d) 98.63% compared to head (57056d9) 98.67%.

❗ Current head 57056d9 differs from pull request most recent head 1dac9dc. Consider uploading reports for the commit 1dac9dc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   98.63%   98.67%   +0.04%     
==========================================
  Files           6        6              
  Lines         292      302      +10     
==========================================
+ Hits          288      298      +10     
  Misses          4        4              
Impacted Files Coverage Δ
lib/smartcar/vehicle.rb 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@EvanPeterson1324 EvanPeterson1324 marked this pull request as ready for review April 13, 2023 17:30
@s-ashwinkumar
Copy link
Contributor

Missing version bump, i am going to add that in

@EvanPeterson1324 EvanPeterson1324 merged commit 234555d into master Apr 14, 2023
@EvanPeterson1324 EvanPeterson1324 deleted the charge-lmit branch April 14, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants