Merged
Conversation
Collaborator
|
Is this exact approach already broadly established in the modding community? Also, I would consider putting a calling convention and |
Contributor
Author
|
Usually we would do a ton of math and tests to find the pointer offset ourselves, but this makes my life less hell Other than that yes |
Collaborator
|
I understand, but we need a calling convention and extern "C" to avoid MSVC artifacts and make this compatible with other compilers |
Contributor
Author
|
I put one already |
Collaborator
|
Ah, didn't see the extern "C" at the first look, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a simple hook for modloading systems, including my own
Changes
Added hook for potential modloaders
See https://github.com/DanielLMcGuire/LCE-SDK