Render custom skin boxes on viewmodel#1415
Merged
sylvessa merged 3 commits intosmartcmd:mainfrom Mar 28, 2026
Merged
Conversation
Contributor
Author
|
DO NOT MERGE YET!!! somehow missed a bug last night where selecting a skin with no boxes at all will crash the game. |
Contributor
Author
|
Ok newest commit should fix 👍 |
Collaborator
|
will merge when workflow succeeds |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the custom skin boxes not being rendered on the viewmodel.
Changes
The custom skin boxes now correctly render with the viewmodel.
Previous Behavior
Previously the custom skin boxes did not render, which wasn't a huge issue unless you were using a model that replaces the default arm with a custom box while hiding the original arm with an anim bitmask. In this screenshot you can see what the sackboy skin looks like in first person mode right now.

Root Cause
Game just wasn't rendering the boxes with the viewmodel as it should and does in official console versions of the game.
New Behavior
Here, you can see that the game now properly renders the custom skin boxes with the viewmodel.


Fix Implementation
Loop through children of arm0 and see if they match the ModelParts that are for the current skin, if they do render them with the viewmodel.
AI Use Disclosure
None
Related Issues