Merged
Conversation
…compatibility Shcore.dll and SetProcessDpiAwareness were introduced in Windows 8 and higher, so to keep compatibility with Windows 7, we use GetProcAddress to call this function dynamically, avoiding linker writing binary dependency on shcore.dll in the import table
…ndows 7 compatibility" This reverts commit f1f397f.
|
Please squash these reverts, or use |
Collaborator
Author
|
Fixed finally with 796a743 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Shcore.dll and SetProcessDpiAwareness were introduced in Windows 8 and higher, so to keep compatibility with Windows 7, we use GetProcAddress to call this function dynamically, avoiding linker writing binary dependency on shcore.dll in the import table.
Changes
Previous Behavior
After #133, the game started to depend on
shcore.dll, which is present on Windows 8 and higher and call the functionSetProcessDpiAwarenessvia the import table.Root Cause
SetProcessDpiAwarenessandshcore.dllaren't present on Windows 7New Behavior
This fix restores Windows 7 compatibility
Fix Implementation
dynamically call
SetProcessDpiAwarenessviaGetProcAddressviaLoadLibraryExW.Related Issues