Merged
Conversation
Collaborator
|
Have you tested it yourself? Does the cmake build work fully? |
Contributor
Author
|
Yes I tested on both Debug and Release |
Collaborator
|
Ready to merge? |
Contributor
Author
|
Actually, im gonna draft this real quick as I realized the same thing can be done for the language files |
Contributor
Author
|
(idk how to draft) |
Contributor
Author
|
Made it ignore the xml and lang files as they are not used, also ignores the Layout folder as it only includes a binary that isnt used Runs fine on Release, currently compiling Debug and will test Also fixed a compile error due to WinsockNetLayer not being in ClientSources.cmake Tested on both Debug and Release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
This fixes the CopyAssets.cmake script to properly copy over the correct files instead of copying every file
Also changed to to only copy over Minecraft.Client/Common/Media/MediaWindows64.arc instead of all Minecraft.Client/Common/Media/ files and the other platform .arc files
Changes
Previous Behavior
Would copy everything over, making file sizes larger
New Behavior
Only copies the correct and used files