feat: TU19 (Dec 2014) Features & Content#32
Conversation
# Conflicts: # Minecraft.Client/ClientConnection.cpp # Minecraft.Client/Common/UI/UIController.cpp
# Conflicts: # Minecraft.Client/LocalPlayer.cpp
# Conflicts: # Minecraft.Client/Common/Consoles_App.cpp
|
Yes, I wonder why it wasn't included with the initial commit. Though I need to thoroughly review this one. |
|
Jumping does not work (sometimes? issue with this repo only, not OG src), has some potential rendering bug "regressions" vs current head Main menu behaves strangely in a kinda "debuggy" way vs normal version, tutorial is missing |
|
This is bad. I think we should prioritize stability over feature-richness. |
|
Obviously needs work before it can be merged but it's a base to get these features / this code in with a bit more work |
|
LGTM! |
|
@smartcmd switched to full PR if you'd like to merge |
Oh wdym, of course I really want to merge this |
|
up to you - there's a few graphical and ui quirks with the December code, though merging now would prob make it less of a mess to include in the future and get more eyes on fixing up this version if anything. |
|
Shouldn't this be its own branch? It might be nice to have two concurrent console versions working. |
|
There is just too much changes. I would hesitate to merge until it is thoroughly tested because it seems like a pre-release thing. |
# Conflicts: # .gitignore # Minecraft.Client/Common/UI/UIScene_SkinSelectMenu.cpp # Minecraft.Client/LevelRenderer.h
|
After further testing
|
|
World names were fixed in #37, try to git pull from main |
|
Audio is completely broken now, crashes |
|
Fixed, added file from old hardcoded location to the proper place :P |
|
Save titles are still just timestamps in this version, seems to be irrelevant to main branch |
void2012
added
enhancement
|
hello! It says "help wanted" as a label, but I'm an amateur coder, but I wanna help, so I'm going to test this out for bugs and report later, if that works as helping. |
|
First bug I noticed, Q and E don't work for switching tabs. |
|
Another bug is you take damage in one block deep water, I know that was a thing in the early days in Minecraft, but I'm unsure about TU19. |
Also, every world title shows up as this... [EDIT] The L in Load is also wonky.
|
|
i might be mistaken but I cant seem to find some building blocks added in tu19 in this pr, them being hardened clay, stained clay, block of coal, hay bale, and also block of redstone. there are some other things, such as that I cant find any instance of witch huts. i might be wrong and you may have actually implemented these, but this is just what i found after a quick search. (im basing everything on https://minecraft.wiki/w/Xbox_360_Edition_TU19) |
|
This is based on the December 2014 4J codebase and is not my implementation of any of these features. If anything is missing, it's just like that. |
|
This should be pushed, any minor bug can be fixed later |
|
Yes, once the branch conflict is resolved |
|
Resolve the conflicts and we will merge it c: |
* try to resolve merge conflict * feat: TU19 (Dec 2014) Features & Content (#32) * December 2014 files * Working release build * Fix compilation issues * Add sound to Windows64Media * Add DLC content and force Tutorial DLC * Revert "Add DLC content and force Tutorial DLC" This reverts commit 97a4399. * Disable broken light packing * Disable breakpoint during DLC texture map load Allows DLC loading but the DLC textures are still broken * Fix post build not working * ... * fix vs2022 build * fix cmake build --------- Co-authored-by: Loki <lokirautio@gmail.com>
9 participants
Semi-working December 2014 features and content. Needs more cleanup but adds stuff missing from the more complete October stuff. Bootable with Release build in Windows64. Features are incomplete and buggy but present.
