Closed
Conversation
|
+1 please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pressing pause on high frame-rate (200-300+ fps, I'm not sure but the issue isn't as bad on lower fps) causes CANCEL and PAUSEMENU to be occasionally executed at unwanted times. So pressing escape while in the inventory could back you out into the pause menu with a single press.
Changes
Video of Before and After
Previous Behavior
Press pause once with over 200-300 fps, then have
Alternatively, open inventory, press escape once to back out, then get sent to the pause menu.
Root Cause
Obviously, B and pause weren't meant to be bound to the same button, so an additional check needs to be made to prevent pause being executed directly after B.
New Behavior
Input just checks if an existing UI is open before pushing PAUSEMENU.
Fix Implementation
Added
!ui.GetMenuDisplayed(i)Here ->
if(g_KBMInput.IsKeyPressed(KeyboardMouseInput::KEY_PAUSE) && !ui.IsTutorialVisible(i) && !ui.GetMenuDisplayed(i))