Skip to content

Fix boat gravity#651

Merged
codeHusky merged 1 commit intosmartcmd:mainfrom
MozzarellaRat:main
Mar 6, 2026
Merged

Fix boat gravity#651
codeHusky merged 1 commit intosmartcmd:mainfrom
MozzarellaRat:main

Conversation

@MozzarellaRat
Copy link
Contributor

@MozzarellaRat MozzarellaRat commented Mar 6, 2026

Image of boat falling...
image

Description & Changes

Fixes #266
Reimplements removed gravity from #615 (#615 unintentionally removes boat gravity)
Removes unreachable code
Comments code
Fixes splash particles rendering anywhere, instead of just in water.

Previous Behavior

Boats did not have gravity
Boats would fall through land on a passenger being added
Boats would render splash particles when going fast enough, even when not in water.

Root Cause

#615 improves boat bobbing which also handled gravity.
Boats were intersected with the ground, causing them to fall through the ground
Splash particles did not check for water, just high velocity.

New Behavior

Boats now have gravity
Boats no longer phase through blocks on ride.
Splash particles render in water.

Related Issues

reimplements boat gravity
@MozzarellaRat
Copy link
Contributor Author

It should be noted that users in #266 talk about that being the cause of ice boating not working, it is not. Ice boating was not implemented in this version.

@codeHusky
Copy link
Collaborator

Could you add a video or smthn? a picture doesn't really show gravity lol

@MozzarellaRat
Copy link
Contributor Author

MozzarellaRat commented Mar 6, 2026

I do not have a video recorder, sorry. But you can checkout the commit. I could add a photo showing the fix between #266 ( Which is just the positioning fix in the constructor ).

Could you add a video or smthn? a picture doesn't really show gravity lol

@fayaz12g
Copy link
Contributor

fayaz12g commented Mar 6, 2026

I do not have a video recorder

Both AMD and Nvidia GPU software have an overlay that opens a recorder with Alt+Z

@MozzarellaRat
Copy link
Contributor Author

Here is the video of a boat falling as requested.

wowaboat.mp4

@MozzarellaRat
Copy link
Contributor Author

MozzarellaRat commented Mar 6, 2026

If you were looking for a video showing a difference, the boat wouldn't have fallen. I will not be uploading a video of that, but I'm sure you can see the difference from the image below.

image

@MozzarellaRat
Copy link
Contributor Author

This also fixes splash particles rendering anywhere, not just water. Forgot to mention that.

@codeHusky codeHusky merged commit c455410 into smartcmd:main Mar 6, 2026
1 check passed
tm5k pushed a commit to tm5k/RickCraft that referenced this pull request Mar 7, 2026
reimplements boat gravity
tm5k pushed a commit to tm5k/RickCraft that referenced this pull request Mar 8, 2026
reimplements boat gravity
piebotc pushed a commit to piebotc/LegacyEvolved that referenced this pull request Mar 9, 2026
reimplements boat gravity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Boats fall underground...

3 participants