Merged
Conversation
reimplements boat gravity
Contributor
Author
|
It should be noted that users in #266 talk about that being the cause of ice boating not working, it is not. Ice boating was not implemented in this version. |
Collaborator
|
Could you add a video or smthn? a picture doesn't really show gravity lol |
Contributor
Author
|
I do not have a video recorder, sorry. But you can checkout the commit. I could add a photo showing the fix between #266 ( Which is just the positioning fix in the constructor ).
|
Contributor
Both AMD and Nvidia GPU software have an overlay that opens a recorder with Alt+Z |
Contributor
Author
|
Here is the video of a boat falling as requested. wowaboat.mp4 |
Contributor
Author
Contributor
Author
|
This also fixes splash particles rendering anywhere, not just water. Forgot to mention that. |
tm5k
pushed a commit
to tm5k/RickCraft
that referenced
this pull request
Mar 7, 2026
reimplements boat gravity
tm5k
pushed a commit
to tm5k/RickCraft
that referenced
this pull request
Mar 8, 2026
reimplements boat gravity
piebotc
pushed a commit
to piebotc/LegacyEvolved
that referenced
this pull request
Mar 9, 2026
reimplements boat gravity
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Image of boat falling...

Description & Changes
Fixes #266
Reimplements removed gravity from #615 (#615 unintentionally removes boat gravity)
Removes unreachable code
Comments code
Fixes splash particles rendering anywhere, instead of just in water.
Previous Behavior
Boats did not have gravity
Boats would fall through land on a passenger being added
Boats would render splash particles when going fast enough, even when not in water.
Root Cause
#615 improves boat bobbing which also handled gravity.
Boats were intersected with the ground, causing them to fall through the ground
Splash particles did not check for water, just high velocity.
New Behavior
Boats now have gravity
Boats no longer phase through blocks on ride.
Splash particles render in water.
Related Issues