Implement basic multiplayer functionality#96
Closed
simulpingus wants to merge 2 commits intosmartcmd:mainfrom
Closed
Implement basic multiplayer functionality#96simulpingus wants to merge 2 commits intosmartcmd:mainfrom
simulpingus wants to merge 2 commits intosmartcmd:mainfrom
Conversation
JPeisach
reviewed
Mar 2, 2026
| if (m_SessionsUpdatedCallback == NULL) | ||
| return; | ||
|
|
||
| static DWORD lastSearchTime = 0; |
There was a problem hiding this comment.
maybe we can just use "int" here because weren't in Microsoft specific code (at least I don't think)
| #else | ||
| typedef struct _GameSessionData | ||
| { | ||
| unsigned short netVersion; // 2 bytes |
There was a problem hiding this comment.
It's probably worth keeping it here for the sake of structure alignment purposes
| delete (*it); | ||
| } | ||
| } | ||
| delete m_currentSessions; |
There was a problem hiding this comment.
Are we sure that this is sufficient for all compilers?
Collaborator
|
This PR seems to be outdated. Is the fork being the test site for current? |
void2012
added
priority: low
multiplayer
Merged
void2012
pushed a commit
that referenced
this pull request
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Implements basic LAN functionality
launch_arguments:
name: -name usage: "-name " description: Sets your in-game username.
name: -ip usage: "-ip " description: > Manually connect to an IP if LAN advertising does not work or if the server cannot be discovered automatically.
name: -port usage: "-port " description: > Override the default port if it was changed in the source.
example: command: "Minecraft.Client.exe -name Steve -ip 192.168.0.25 -port 25565"
Changes
See commit
Directly sourced from https://github.com/LCEMP/LCEMP
